fix: add no-cache header to index.html#66
Merged
Conversation
…loaded The catch-all location block serving index.html had no Cache-Control header, allowing browsers to use heuristic caching. This could cause stale index.html to reference old hashed assets after a deployment, resulting in 404 errors and blank screens. Adding no-cache ensures browsers always revalidate index.html with the server while still benefiting from 304 responses when unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache-Control: no-cacheto the catch-alllocation /block that servesindex.htmlindex.htmlwith the server, so new deployments are picked up immediately304 Not Modifiedwhen unchanged (no re-download)Problem
The
index.htmlentry point had noCache-Controlheader, so browsers could use heuristic caching and serve a stale version. After a deployment, the staleindex.htmlwould reference old hashed JS/CSS filenames that no longer exist, causing 404 errors and blank screens.Test plan
index.htmlresponse includesCache-Control: no-cacheheaderCache-Control: publicwith 1-year expiry