fix: use mailto: placeholder for obfuscated contact links#80
Merged
Conversation
The #contact href caused SvelteKit prerender to fail because no element with id="contact" exists. Using mailto: as a safe fallback that gets replaced by JS at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
href="#contact"withhref="mailto:"on obfuscated contact links#contacthref caused SvelteKit prerender to fail because no element withid="contact"exists on the pagemailto:is a safe placeholder that gets replaced by the real address via JS at runtimeTest plan
npx svelte-kit sync && npm run build)mailto:info@postguard.euon mount)