feat: add FF_BUSINESS feature flag for PostGuard for Business#81
Merged
Conversation
Wire up window.APP_CONFIG (from Terraform ConfigMap) to control visibility of the Business nav link, landing page section, and footer link. The flag is read at runtime from config.js, which is overridden per environment in deployed clusters.
The ConfigMap-mounted config.js is read-only, so sed -i fails when it tries to create a temp file. Exclude it from the find since it never contains VITE placeholders anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FF_BUSINESSto control visibility of all PostGuard for Business contentwindow.APP_CONFIGfrom Terraform ConfigMap (fixes mount path from/var/www/html/to/usr/share/nginx/html/postguard/)static/config.jswith development defaults (FF_BUSINESS: true)config.jsinapp.htmlbefore the app boots$lib/env.tsand use it to conditionally render:Requires companion changes in postguard-ops (same branch name):
variables.tf: newpostguard_ff_businessvariable (defaultfalse)main.tf: addFF_BUSINESSto ConfigMap, fix volume mount pathenvironments/dev.tfvars:postguard_ff_business = trueenvironments/prod.tfvars:postguard_ff_business = falseTest plan
npx svelte-check --threshold warningpasses (0 errors, 0 warnings)true)FF_BUSINESS: true)FF_BUSINESS: false)