-
Notifications
You must be signed in to change notification settings - Fork 220
Add Singularidad StoryQuest #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Singularidad StoryQuest #1626
Conversation
manuq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
I see that you have iterated on my review of the first pull request, thanks! May I ask why you closed that one and opened this one? The first one was from your branch generate_storyquest and this one is from your branch adding_storyquest. I would recommend that you just open pull requests from your main branch directly.
As mentioned in the first pull request:
Please check the submission guide. In particular the section "Commit & PR structure". You are missing the second point in this pull request description:
Attribution sections titled as Assets, Engineering, Game Design, and Production & Management. These should reference GitHub usernames of the contributors, as specified for each category below: (...)
Basically, you need to provide the list of GitHub users in your team, and who worked on what for this pull request in each area (assets, engineering, game design, and production/management).
You can also check how this team did it, for reference: #1561
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I overlooked when reviewing #1538. This is the tileset used for the whole game. I'm sorry but you can't modify it. Instead, you should:
- Duplicate this file to your own StoryQuest folder. For example to
singularity_tileset.tres - Change the TileMapLayers in your scenes to use your own copy.
- Restore this
scenes/tileset.tresfile to how it was before.
|
Play this branch at https://play.threadbare.game/branches/Game-Lab-5-0-UTP-Group-7-Team-6/adding_storyquest. (This launches the game from the start, not directly at the change(s) in this pull request.) |
|
@PrismenoDrako I hope that you can make the extra effort and apply to the submission guidelines. I would love to see this stealth level (with nice circuit board tileset and robots) in the main game. |
|
@PrismenoDrako we decided to keep all StoryQuests PRs open for 3 weeks. Upon that time, if we don't hear back from you, we'll be closing them. If you can, please apply our suggestions so we can merge the PR. Thanks! |


No description provided.