Skip to content

Conversation

@PrismenoDrako
Copy link

No description provided.

@PrismenoDrako PrismenoDrako requested a review from a team as a code owner November 17, 2025 22:52
Copy link
Collaborator

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!
I see that you have iterated on my review of the first pull request, thanks! May I ask why you closed that one and opened this one? The first one was from your branch generate_storyquest and this one is from your branch adding_storyquest. I would recommend that you just open pull requests from your main branch directly.

As mentioned in the first pull request:

Please check the submission guide. In particular the section "Commit & PR structure". You are missing the second point in this pull request description:

Attribution sections titled as Assets, Engineering, Game Design, and Production & Management. These should reference GitHub usernames of the contributors, as specified for each category below: (...)

Basically, you need to provide the list of GitHub users in your team, and who worked on what for this pull request in each area (assets, engineering, game design, and production/management).

You can also check how this team did it, for reference: #1561

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I overlooked when reviewing #1538. This is the tileset used for the whole game. I'm sorry but you can't modify it. Instead, you should:

  • Duplicate this file to your own StoryQuest folder. For example to singularity_tileset.tres
  • Change the TileMapLayers in your scenes to use your own copy.
  • Restore this scenes/tileset.tres file to how it was before.

@github-actions
Copy link

Play this branch at https://play.threadbare.game/branches/Game-Lab-5-0-UTP-Group-7-Team-6/adding_storyquest.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq manuq added the StoryQuest New StoryQuests or updates to existing ones label Nov 18, 2025
@PrismenoDrako PrismenoDrako requested a review from a team as a code owner November 19, 2025 22:34
@manuq
Copy link
Collaborator

manuq commented Nov 26, 2025

Quest review:

Fantastic tileset with circuit board!

Level 1 stealth, I love the level design!

image

This level would really benefit from dimming the global illumination (adding a CanvasModulate node). Otherwise the guard's detection areas (light cones) aren't very visible.

In level 2 I like the robot enemy design so much. Other than that, I think it can be cut, because it is too similar to the template combat level and there is not much gameplay. But up to you! Is also fine to keep it as a resting moment.

The outro is nice, with just dialogue from "father". I love it.

image

@manuq
Copy link
Collaborator

manuq commented Nov 26, 2025

@PrismenoDrako I hope that you can make the extra effort and apply to the submission guidelines. I would love to see this stealth level (with nice circuit board tileset and robots) in the main game.

@manuq
Copy link
Collaborator

manuq commented Dec 2, 2025

@PrismenoDrako we decided to keep all StoryQuests PRs open for 3 weeks. Upon that time, if we don't hear back from you, we'll be closing them. If you can, please apply our suggestions so we can merge the PR. Thanks!

@manuq manuq changed the title Agregando la storyquest Add Singularidad StoryQuest Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

StoryQuest New StoryQuests or updates to existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants