Add SFX for FragileBarrel #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds 'cracks.wav' and 'breaking.wav' assets using AudioStreamRandomizer. - Implements pitch randomization (1.1) as requested. - Integrates sound playback into FragileBarrel script. fix: #1647
|
Test build no longer available. |
manuq
approved these changes
Dec 4, 2025
Collaborator
manuq
left a comment
manuq
left a comment
There was a problem hiding this comment.
The selected sounds are great! I feel that the crack sounds are a bit too low compared with the other sounds in the level. I would expect them to be noisier than the flutter sound in the enemy. Maybe is the flutter sound that is too high? Sorry, I'm no expert in audio.
Well implementation, I only requested 2 small things to change.
scenes/quests/lore_quests/quest_003/2_ink_drinker_levels/components/fragile_barrel.gd
Outdated
Show resolved
Hide resolved
scenes/quests/lore_quests/quest_003/2_ink_drinker_levels/components/fragile_barrel.gd
Outdated
Show resolved
Hide resolved
...quests/lore_quests/quest_003/2_ink_drinker_levels/components/sounds/sfx_barrel_breaking.tres
Show resolved
Hide resolved
Co-authored-by: Manuel Quiñones <[email protected]>
wjt
approved these changes
Dec 5, 2025
Member
wjt
left a comment
wjt
left a comment
There was a problem hiding this comment.
I agree that the crack sound is a little low in the mix. I'll spend a few minutes with Audacity…
scenes/quests/lore_quests/quest_003/2_ink_drinker_levels/components/fragile_barrel.gd
Outdated
Show resolved
Hide resolved
…nents/fragile_barrel.gd Co-authored-by: Manuel Quiñones <[email protected]>
Trim a little silence from the start of the sample. Normalize the peak volume to -3 dB to better match the amplitude of other sounds in the level. Convert to Ogg Vorbis.
The other resource is called "sfx_barrel_crack". This one had a typo in the abbreviation "sfx", and didn't have a verb for what the sound effect is for.
github-project-automation
bot
moved this from In Progress
to Done
in Threadbare Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements audio for the FragileBarrel mechanic.
Changes:
cracksandbreakingsound effects assets.AudioStreamRandomizerwith a 1.1 pitch variation to prevent repetition.FragileBarrelscript and scene to trigger sounds on damage and destruction.🎮 Play Ink Drinker Level 5
Play Ink Drinker Level 5
resolves #1647