shjourney: Remove stray instance of directional_input_hint.gd #1703
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shjourney: Remove stray instance of directional_input_hint.gd
This scene has a TextureRect with directional_input_hint.gd attached.
Its name is InteractInput which might lead one to suspect that the
script attached used to be different. And indeed before
commit 9d03c40 and
commit 783701b the attached script was
input_key.gd which was as follows:
This relied on the scene designer setting the correct texture for the
corresponding button. The action_name property was set to "running" in the
scene.
Over the course of those two commits, this simple script morphed into the
directional_input_hint.gd script that we have today, and the action_name was
unset. As a result, when you run this scene, the following is printed on each
physics frame:
However, having looked through the Git commit history for the original fork, the
TextureRect node that the script is attached to has never had a texture assigned
to it; so it has never had any visible effect. Its functional purpose is to be
the parent to a Label that reads "Puerta desbloqueada" (door unlocked), which is
hidden at the start of the scene, and temporarily made visible when the player
collects the final key.
Remove the script, leaving it as a bare, invisible TextureRect. (It's referenced
by path in a script.)