Skip to content

Add a red flash when the player takes damage. - #2800

Open
MeLoNaCo wants to merge 2 commits into
endlessm:mainfrom
MeLoNaCo:main
Open

Add a red flash when the player takes damage.#2800
MeLoNaCo wants to merge 2 commits into
endlessm:mainfrom
MeLoNaCo:main

Conversation

@MeLoNaCo

Copy link
Copy Markdown

Issue #1743
I updated the player's GotHitAnimation node to flash between red, white, transparent red, and white when taking damage.

@MeLoNaCo
MeLoNaCo requested a review from a team as a code owner August 27, 2026 23:17
@manuq

manuq commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@MeLoNaCo as you have found, a "got hit" animation already existed, but it was more subtle (the player going from semitransparent to fully visible). Please attach before/after videos so we can see the difference. It very useful attach videos or images in these kind of tasks.

@github-actions

Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/MeLoNaCo/main/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq manuq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeLoNaCo looks great! Please update the pull request title and description to reflect the actual changes (white, not red). Also the description should have a last line saying "Resolves URL" being URL the link to the task. See https://github.com/endlessm/threadbare/wiki/Contributing#pull-request-descriptions

After you do the changes in title and description, we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants