Fix townies walking speed issue #2620 - #2809
Open
Nickssssss-del wants to merge 1 commit into
Open
Conversation
manuq
requested changes
Aug 31, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
Before I continue with the review, I would like to see the unneeded changes reverted.
Comment on lines
-12
to
+15
| ## Call [member RetellingTownie.go_to_the_loom()] on each townie so they join. | ||
| ## Call [member EternalLoom.show_retelling_dialogue()] when all townies have joined. | ||
| ## May call [member RetellingTownie.become_helper()] on one townie (at random). | ||
| ## Call [member RetellingTownie.leave_the_loom()] on each townie so they leave. | ||
| ## Call RetellingTownie.go_to_the_loom() on each townie so they join. | ||
| ## Call EternalLoom.show_retelling_dialogue() when all townies have joined. | ||
| ## May call RetellingTownie.become_helper() on one townie (at random). | ||
| ## Call RetellingTownie.leave_the_loom() on each townie so they leave. |
Collaborator
There was a problem hiding this comment.
Please explain why you changed the documentation comments.
|
|
||
| ## The Eternal Loom, for listening to signals and calling | ||
| ## [member EternalLoom.show_retelling_dialogue()]. | ||
| ## EternalLoom.show_retelling_dialogue(). |
Comment on lines
-30
to
+39
| eternal_loom.retelling_started.connect(_on_eternal_loom_retelling_started) | ||
| eternal_loom.retelling_finished.connect(_on_eternal_loom_retelling_finished) | ||
| eternal_loom.give_retelling_upgrade.connect(_on_eternal_loom_give_retelling_upgrade) | ||
|
|
||
| eternal_loom.retelling_started.connect( | ||
| _on_eternal_loom_retelling_started | ||
| ) | ||
| eternal_loom.retelling_finished.connect( | ||
| _on_eternal_loom_retelling_finished | ||
| ) | ||
| eternal_loom.give_retelling_upgrade.connect( | ||
| _on_eternal_loom_give_retelling_upgrade | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why change the format here? Check https://github.com/endlessm/threadbare/actions/runs/33290260227/job/99564258513?pr=2809 and please consider installing pre-commit like our Contributing guide mentions.
|
Play this branch at https://play.threadbare.game/branches/Nickssssss-del/fix-townies-speed-clean/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update 1 — Adjusting the Townies' Speed
Tests were conducted with different speed ranges to improve the pacing of the retelling scene, as the townies could move too slowly and make the scene feel drawn out. After comparing different values, the 175–264 px/s range was selected, as it provided smoother, more appropriate movement without making the characters feel too fast.
Evidence:
175-264.mp4
Update 2 — Arrival Synchronization
A system was implemented to synchronize the townies’ arrival at the Eternal Loom. The distance traveled, assigned speed, and estimated travel time are calculated individually for each character. Then, the longest travel time is used as a reference, and a start delay is calculated for the other townies.
Evidence:
Sincronizacion.1.mp4