-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[New product] Knative #9159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[New product] Knative #9159
Conversation
Signed-off-by: saltbo <[email protected]>
|
Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals. |
|
Thanks for the PR! One minor note: The core components went GA with 1.0, so we can drop the 0.x releases. We focus only on stable/GA releases, and while knative was widely used (in production setups) even pre-1.0, 1.0 was the first documented GA release. |
captn3m0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Left a review with comments for most suggested changes. Beyond that, it would be nice to have customFields added to documented the minK8sVersion as well. See tomcat.md for a sample: https://github.com/endoflife-date/endoflife.date/blob/master/products/tomcat.md?plain=1
Co-authored-by: Nemo <[email protected]>
Co-authored-by: Nemo <[email protected]>
Co-authored-by: Nemo <[email protected]>
Co-authored-by: Nemo <[email protected]>
Co-authored-by: Nemo <[email protected]>
Co-authored-by: Nemo <[email protected]>
a8bd0ee to
19c59b4
Compare
Signed-off-by: saltbo <[email protected]>
19c59b4 to
c681f0f
Compare
Since releases are every quarter, this would come out to 2quarters+1week ~= 6 months. I don't see the 9 month claim upstream either. |
Surprisingly, Knative is not included, I will contribute.