-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[New Product] Roku #9243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[New Product] Roku #9243
Conversation
captn3m0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page needs a rework because it is unclear if the page is documenting Roku OS, or Roku Devices. I think it should be the latter. Apple devices have a similar problem, and we track /ios separate from /iphone.
In this page, the biggest problem is the latest column, which is supposed to denote the "latest release in that release cycle". Since a release cycle is a hardware line, it doesn't make sense and we shouldn't be documenting it. Putting an OS version is incorrect here. The page should also clarify that we're tracking devices and not the OS.
We can however still document the HighestRokuOSVersion via a custom column perhaps (see https://endoflife.date/fairphone for eg).
My understanding is that Roku OS 15 is the only supported OS, and any device not receiving a 15 upgrade is effectively EOL. That is what needs to be visible at the page. The policy text should also clarify the same.
We can also perhaps switch to just using the alphanumeric codes for the releasecycles, since they are quite unique, and use releaseLabels for the brand text.
And finally, the page ought to cover the last 2 generation of devices to be the most helpful - otherwise it is an unreliable stub for most users.
| identifiers: | ||
| - cpe: cpe:2.3:h:roku:roku_os | ||
| - cpe: cpe:2.3:h:roku:ultra | ||
| - cpe: cpe:2.3:h:roku:roku_tv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since https://nvd.nist.gov/vuln/detail/CVE-2018-11314 links to the firmware CPE.
| - cpe: cpe:2.3:h:roku:roku_tv | |
| - cpe: cpe:2.3:h:roku:roku_tv | |
| - cpe: cpe:2.3:h:roku:roku_firmware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I made those updates, except wanted to get the format figured out before doing device full population. Once its "stable" I can do that. Also there are lots of CPEs floating around for Roku devices depending on which CVE you look at. I added the full list at: https://www.cvedetails.com/product-list/product_type-h/vendor_id-19030/firstchar-/Hardwares.html
Updated as code block to show backslashes correctly. |
No description provided.