Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compartment-mapper: support for wildcards in subpath exports #2741

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

compartment-mapper: support for wildcards in subpath exports #2741

wants to merge 8 commits into from

Conversation

boneskull
Copy link
Contributor

DRAFT, WIP, ETC.

Closes: #XXXX
Refs: #XXXX

Description

Add a description of the changes that this PR introduces and the files that are the most critical to review.

Security Considerations

Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls?

Scaling Considerations

Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated?

Documentation Considerations

Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users?

Testing Considerations

Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet?

Compatibility Considerations

Does this change break any prior usage patterns? Does this change allow usage patterns to evolve?

Upgrade Considerations

What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed?

Include *BREAKING*: in the commit message with migration instructions for any breaking change.

Update NEWS.md for user-facing changes.

Delete guidance from pull request description before merge (including this!)

kriskowal and others added 7 commits October 24, 2024 15:34
@kriskowal
chore(regexp-escape): Scaffold
b1f52bd
@kriskowal
chore: Update yarn.lock
ca089de
@kriskowal
feat(regexp-escape): Userland RegExp.escape ponyfill
51ec9b0
@kriskowal
feat(compartment-mapper): Add subpath match and replace utility
76a089a
@kriskowal
chore(compartment-mapper): Update yarn.lock
6490c65
@boneskull
Merge branch 'master' into kriskowal-export-subpath
8dfd216 
* master: (152 commits)
  fix(ses): lockdown options should be kebob-case (#2739)
  feat(import-bundle): Test bundle format #2719
  chore: Update yarn.lock
  refactor(ses): Compensate Hermes transform for Babel upgrade
  feat(bundle-source)!: Replace getExport and nestedEvaluate implementations with endoScript implementation
  refactor(evasive-transform): Relieve dependence on Rollup
  chore(evasive-transform): Update golden masters
  refactor(evasive-transform): Add sourceMap option, remove unmapLoc
  chore(evasive-transform): Update sourcemap test snapshot
  chore: yarn up @babel/generator
  refactor: Migrate from @agoric/babel-generator back to @babel/generator
  chore: Upgrade Babel
  fix: Update version management scripts
  refactor(module-source): More compact boilerplate
  refactor(module-source): Converge file naming convention
  feat(evasive-transform): Preserve format with Babel
  feat(module-source): Preserve format with Babel integration
  test(module-source): Add format preservation test
  chore(ses): add explicit devDependencies on Babel packages
  refactor(ses): compartmentImport without function.bind
  ...
@boneskull
chore(compartment-mapper): implement trie-based pattern matcher (wip)
5b53567
@boneskull boneskull self-assigned this Mar 14, 2025
@boneskull
chore(compartment-mapper): more subpath work
bce6868 
- Move types from `@typedef`s into `types/subpath.ts`
- Add `PathTrie.fromJSON` and `PathTrie.fromTrie`
- Make `PathTrie` and `PathTrieNode` constructors accept `root` and `value` parameters, respectively
- Add a bunch of docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@boneskull boneskull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boneskull @kriskowal