Skip to content

feat(patterns): Expand special-casing of "optionality" patterns #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

gibson042
Copy link
Contributor

Description

Rather than limiting the special behavior to M.or(M.undefined(), other), also apply it to M.or(undefined, other) and to reversed-order analogs (i.e., other-first).

Security Considerations

None known.

Scaling Considerations

None known.

Documentation Considerations

n/a

Testing Considerations

n/a

Compatibility Considerations

n/a

Upgrade Considerations

n/a

@gibson042 gibson042 requested review from kriskowal and erights April 4, 2025 16:47
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Rather than limiting the special behavior to `M.or(M.undefined(), other)`, also
apply it to `M.or(undefined, other)` and to reversed-order analogs (i.e.,
`other`-first).
@gibson042 gibson042 force-pushed the gibson-2025-04-optional-pattern-messages branch from 6209ceb to 740cc8d Compare April 9, 2025 16:40
@gibson042 gibson042 merged commit 1c9cd7f into master Apr 9, 2025
16 checks passed
@gibson042 gibson042 deleted the gibson-2025-04-optional-pattern-messages branch April 9, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants