Skip to content

chore(compartment-mapper): remove vacuous assertion from module source hook test #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boneskull wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(compartment-mapper): remove vacuous assertion from module source hook test #3122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/compartment-mapper/test/make-import-hook-maker.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ test(
);

test('captureFromMap - moduleSourceHook - receives correct parameters w/ implicit dependency', async t => {
t.plan(5);
t.plan(4);
const readPowers = makeReadPowers({ fs, url });
const moduleLocation = new URL(
'fixtures-module-source-hook/node_modules/app-implicit/index.js',
Expand All @@ -178,12 +178,7 @@ test('captureFromMap - moduleSourceHook - receives correct parameters w/ implici
};

const compartmentMap = await mapNodeModules(readPowers, moduleLocation);
t.falsy(
compartmentMap.compartments[compartmentMap.entry.compartment].modules[
'dependency-a>dependency-b'
],
'app-implicit should not have a module reference to dependency-b',
);

t.truthy(
Object.values(compartmentMap.compartments).find(
compartment => compartment.label === 'dependency-a>dependency-b',
Expand Down
Loading