expose simple step_into() for SBThread() #32
Conversation
src/thread.rs
Outdated
| } | ||
|
|
||
| #[allow(missing_docs)] | ||
| pub fn step_into3( |
There was a problem hiding this comment.
Your other suggestion for a name is better. What is the target name parameter actually for?
There was a problem hiding this comment.
Quoting from https://lldb.llvm.org/python_api/lldb.SBThread.html#lldb.SBThread.StepInto:
Step the current thread from the current source line to the line given by end_line, stopping if the thread steps into the function given by target_name. If target_name is None, then stepping will stop in any of the places we would normally stop.
I had trouble getting this to work with default parameters. That's why I added the simple version. Maybe until and target_name should be Option<> and the method then calls the correct low-level method based on the provided params? But what do you call if only until is provided?
This exposes the simple
SBThreadStepIntowith only one parameter asstep_into()and the existing one asstep_into3(better name suggestion welcome, maybestep_into_until()?).