Fix tile rendering skew from lidar outliers (#11)#53
Draft
endolith wants to merge 1 commit into
Draft
Conversation
- Drop LAS noise classes 7 and 18 via streamable filters.expression when filterNoise is enabled, so low/high noise points do not distort DSM grids. - Use percentile-based vmin/vmax for tile PNG rendering so a few extreme high-pass values cannot collapse matplotlib grayscale autoscale. Co-authored-by: endolith <endolith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #11: a few extreme Z values could skew DSM/high-pass range so slippy tiles rendered flat white.
Changes
Noise classes at ingest — When
filterNoiseis on, the PDAL pipeline now uses a streamablefilters.expressionstage to drop ASPRS Classification 7 (low noise) and 18 (high noise), not only class 18. Class 7 is the LAS “low point / noise” bucket that matches the reported very-low spikes;filters.expressionstays compatible withexecute_streaming.Robust tile contrast — Before
imshow, finite values are summarized with the 0.5 and 99.5 percentiles to setvmin/vmax, so a handful of remaining outliers cannot dominate matplotlib’s autoscale. Degenerate cases (empty or constant data) fall back safely.Notes
.laztiles built under the old pipeline still contain old classifications until re-fetched; new fetches get the stricter noise filter. The percentile scaling still improves PNGs from existing DSMs with rare bad pixels.filterNoise(would require a code path exposing that flag to HTTP if desired later).