[android] Fixed menu list remained tappable after dismiss on android

[kesha-antonov]

Hi

Fixes #76

[marco2216]

what does this change do?

[Nasseratic]

This is applying the fix from this PR: https://github.com/enesozturk/react-native-hold-menu/pull/112/files

[marco2216]

what does this do?

[Nasseratic]

I think because we have these styles already in the styles.holdItem

[Nasseratic]

Did not test it, but I guess that this will break the animation when closing the menu.
We might need to wait for the animation somehow and then remove it

[kesha-antonov]

It doesn't brake, you can check it
I set state in the animation callback when it's finished

[Nasseratic]

@kesha-antonov An idea could be to use animatedProps with pointerEvents :)
I believe it can make the fix simpler

[kesha-antonov]

@kesha-antonov An idea could be to use animatedProps with pointerEvents :) I believe it can make the fix simpler

Why to keep rendered views underneath and waste device's resources?

[fukemy]

Hi, I saw the lib render {children} 2 times like this:

<GestureHandler>
        <Animated.View ref={containerRef} style={containerStyle}>
          {children} => * HERE
        </Animated.View>
      </GestureHandler>

      <Portal key={key} name={key}>
        <Animated.View
          key={key}
          style={portalContainerStyle}
          animatedProps={animatedPortalProps}
        >
          <PortalOverlay />
          {children} => * HERE
        </Animated.View>
      </Portal>

So I think that make performance down to hell from here

[kesha-antonov]

Hi, I saw the lib render {children} 2 times like this:

<GestureHandler>

        <Animated.View ref={containerRef} style={containerStyle}>

          {children} => * HERE

        </Animated.View>

      </GestureHandler>



      <Portal key={key} name={key}>

        <Animated.View

          key={key}

          style={portalContainerStyle}

          animatedProps={animatedPortalProps}

        >

          <PortalOverlay />

          {children} => * HERE

        </Animated.View>

      </Portal>

So I think that make performance down to hell from here

You need to address it to main code base, not my PR) I didn't add this logic

[hems]

@kesha-antonov are you still using this library and/or mantaining a fork?

it would be nice to get this working!

perhaps with all the PRs and people interested in this library we could consolidate the fixes and make a new fork with the PRs merged and supporting latest version of Reanimated and Expo?