refactor: Reanimated 4, Modal instead of Portal, Expo SDK 55, leaner deps#124
Open
jcmcneal wants to merge 9 commits intoenesozturk:mainfrom
Open
refactor: Reanimated 4, Modal instead of Portal, Expo SDK 55, leaner deps#124jcmcneal wants to merge 9 commits intoenesozturk:mainfrom
jcmcneal wants to merge 9 commits intoenesozturk:mainfrom
Conversation
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
…m registers via context Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
…deps - Use RN Modal instead of @gorhom/portal for overlay - Require react-native-reanimated >= 4.2, react-native-worklets >= 0.7 - HoldMenuProvider no longer wraps GestureHandlerRootView - Remove HoldItem.theme; theme only via provider - Peer deps for expo-blur, expo-haptics; drop lodash.isequal, nanoid Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Codex to refactor and modernize the package. Summary of changes:
react-native-reanimated >= 4.2andreact-native-worklets >= 0.7; gesture and animation logic updated accordingly.Modalinstead of@gorhom/portal.expo-blurandexpo-hapticsare peer dependencies.@gorhom/portal,lodash.isequal, andnanoidfrom the package.HoldMenuProviderno longer wrapsGestureHandlerRootView; callers must wrap the app withGestureHandlerRootViewand passHoldMenuProviderinside.HoldItem.themewas removed; theme is set only viaHoldMenuProvider’sthemeprop.Breaking: This is a semver-major change (intended as 1.0.0). See README “Breaking changes in 1.0” for migration notes.
I didn’t have time to update the example app or docs in this PR; the library source and README are updated. Happy to iterate on example/docs in follow-ups or maintainer edits.