CI: Use libMainThreadChecker to test if all functions run on the correct thread #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect thread Xcode provides a tool called the “Main Thread Checker” which verifies that UI APIs are being used from the correct thread
pentamassiv
force-pushed
the
ci_macos_main_thread
branch
from
274306f to
f3fa6a3
Compare
|
I think there should be warnings. I thought that the tests run in individual threads. It might be a good idea to add a Tauri example and make sure it doesn't crash even if enigo is used in a new thread (see tauri-apps/tauri#6421 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode provides a tool called the “Main Thread Checker” which verifies that UI APIs are being used from the correct thread. More information can be found here: https://developer.apple.com/documentation/xcode/diagnosing-memory-thread-and-crash-issues-early#Detect-improper-UI-updates-on-background-threads
Tauri crashes when enigo is not used on the main thread. With this tool, we can make sure everything runs on the correct thread