[PLA-2141] fix collection query

[zlayine]

PR Type

Bug fix, Enhancement

---

Description

• Fixed incorrect query in getCollection method to use getCollections with IDs.

• Enhanced getCollections API to support collection IDs as input.

• Updated GraphQL query to include collectionIds parameter.

• Improved pagination logic in loadMoreCollectionsWithObserver method.

---

Changes walkthrough 📝

	Relevant files
Bug fix	Collections.vue Fix and enhance collection handling logic                                resources/js/components/pages/Collections.vue Updated getCollection to use getCollections with IDs. Enhanced pagination logic to support collection IDs. Adjusted method calls to align with API changes. +3/-3
Enhancement	collection.ts Enhance `getCollections` API to support IDs                            resources/js/api/collection.ts Modified getCollections method to accept collection IDs. Updated API call structure to include collectionIds. +2/-1      GetCollections.ts Update GraphQL query to support collection IDs                      resources/js/graphql/query/GetCollections.ts Updated GraphQL query to include collectionIds parameter. Adjusted query structure to support new API requirements. +2/-2

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue The parseInt usage in getCollection method might cause unexpected behavior if searchInput.value is not a valid number or contains non-numeric characters. Consider adding validation or error handling for this input. const res = await CollectionApi.getCollections([parseInt(searchInput.value)]); collections.value = DTOFactory.forCollections(res); API Enhancement Validation The getCollections method now accepts ids and after parameters. Ensure that the GraphQL API handles these parameters correctly and returns the expected data, especially when ids is null or an empty array. static async getCollections(ids: number[] | null = null, after: string | null = null) { const data = { query: queries.GetCollections, variables: { collectionIds: ids, after: after, first: 20, }, };

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Validate numeric input for robustness Ensure that parseInt(searchInput.value) in the getCollection function handles invalid or non-numeric input gracefully to avoid runtime errors or unintended behavior. resources/js/components/pages/Collections.vue [375] -const res = await CollectionApi.getCollections([parseInt(searchInput.value)]); +const inputId = parseInt(searchInput.value); +if (isNaN(inputId)) { + throw new Error("Invalid collection ID"); +} +const res = await CollectionApi.getCollections([inputId]); Suggestion importance[1-10]: 9 Why: The suggestion ensures that invalid or non-numeric input for parseInt(searchInput.value) is handled gracefully, preventing potential runtime errors or unintended behavior. This is a critical improvement for robustness and error prevention.	9
General	Add error handling for API calls Add error handling for the CollectionApi.getCollections call in loadMoreCollectionsWithObserver to manage potential API failures and ensure the application remains stable. resources/js/components/pages/Collections.vue [450] -const res = await CollectionApi.getCollections([], collections.value.cursor); +try { + const res = await CollectionApi.getCollections([], collections.value.cursor); +} catch (error) { + console.error("Failed to load more collections:", error); + return; +} Suggestion importance[1-10]: 8 Why: Adding error handling for the CollectionApi.getCollections call in loadMoreCollectionsWithObserver improves application stability by managing potential API failures. This is a significant enhancement for reliability.	8
	Validate input parameters for API method Validate the ids parameter in the getCollections method to ensure it is either null or an array of numbers, preventing potential API misuse or errors. resources/js/api/collection.ts [6] static async getCollections(ids: number[] | null = null, after: string | null = null) { + if (ids !== null && !Array.isArray(ids)) { + throw new Error("Invalid parameter: ids must be an array of numbers or null"); + } +} Suggestion importance[1-10]: 7 Why: Validating the ids parameter in the getCollections method ensures it is either null or an array of numbers, reducing the risk of API misuse or errors. This is a useful improvement for input validation and robustness.	7