Skip to content

Conversation

@zlayine
Copy link
Contributor

@zlayine zlayine commented Jan 30, 2025

PR Type

Bug fix


Description

  • Fixed wallet session handling in useConnectionStore.

  • Added a check to reset provider if wallet is not connected.

  • Ensured proper return flow when wallet is not connected.


Changes walkthrough 📝

Relevant files
Bug fix
connection.ts
Fix wallet session and connection logic                                   

resources/js/store/connection.ts

  • Added a condition to check if the wallet is not connected.
  • Reset provider to an empty string when wallet is not connected.
  • Ensured early return if wallet connection fails.
  • +7/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Possible Issue

    The added check for !this.wallet resets provider and returns early. Ensure this logic does not unintentionally disrupt other parts of the application relying on provider or walletSession.

    if (!this.wallet) {
        this.provider = '';
    
        return;

    @github-actions
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @zlayine zlayine merged commit 29f66e4 into master Jan 30, 2025
    4 checks passed
    @zlayine zlayine deleted the bugfix/PLA-2156/wallet-connected-issue branch January 30, 2025 11:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Development

    Successfully merging this pull request may close these issues.

    2 participants