Skip to content

Conversation

@enoch3712
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2025 11:48
@enoch3712 enoch3712 linked an issue Apr 8, 2025 that may be closed by this pull request
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

extract_thinker/markdown/markdown_converter.py:198

  • Ensure that pages_data is not empty before calling max() on the pages list to avoid a potential runtime exception. Consider adding a check such as 'if not pages_data: raise ValueError("No page data available")' prior to using max().
if max(pages) > len(pages_data):

tests/test_markdown_converter.py:303

  • PDF_PATH_BULK is used in this test but its definition is not shown in the diff; please ensure that PDF_PATH_BULK is properly defined or imported so that the test runs reliably.
markdown_output = converter.to_markdown(PDF_PATH_BULK, vision=True, pages=[1, 3])

@enoch3712 enoch3712 merged commit 7fa9473 into main Apr 8, 2025
6 checks passed
@enoch3712 enoch3712 deleted the 306-feature-markdown-page-selection branch April 8, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Markdown page selection

2 participants