Skip to content

Invoke evilurl via Bazel #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vorburger wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Invoke evilurl via Bazel #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions BUILD → java/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

sh_test(
name = "evilurl",
srcs = ["evilurl.bash"],
# TODO How to make this work despite the presence of **/BUILD files?!
data = glob(["**/*.java"]),
)
3 changes: 3 additions & 0 deletions tools/evilurl/test.bash → java/evilurl.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,14 @@

set -euo pipefail


allow_list=("java/dev/enola/common/io/resource/UrlResource.java"
"java/dev/enola/common/io/resource/ClasspathResource.java")

# TODO Also grep for .toURL() invocations, and fail for any (new) ones.

echo -n "CDW = "
pwd
found_files=$(find . -name "*.java" -print0 | xargs -0 grep -lE "(^|[^a-zA-Z0-9_.])java\.net\.URL($|[^a-zA-Z0-9_#}])" | while IFS= read -r file; do
file_name=$(basename "$file")
allow_path="${file//.\//}"
Expand Down
3 changes: 0 additions & 3 deletions test.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ fi

tools/version/version.bash

# TODO Remove this once evilurl is Bazel test BUILD integrated...
tools/evilurl/test.bash

# https://github.com/bazelbuild/bazel/issues/4257
echo $ Bazel testing...
if [ -z "${CI:-""}" ]; then
Expand Down