-
Notifications
You must be signed in to change notification settings - Fork 8
build(deps): bump protobuf from 29.2 to 30.2, and remove rules_apple #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the protobuf dependency from version 29.2 to 30.2 in the MODULE.bazel
file, and removes the rules_apple
dependency. The PR description indicates that the build is currently failing, and refers to issue #1218.
Highlights
- Dependency Update: The protobuf dependency has been updated from version 29.2 to 30.2.
- Dependency Removal: The
rules_apple
dependency has been removed from theMODULE.bazel
file. This relates to issue Error: 'struct' value has no field or method 'AppleDynamicFramework' #1146.
Changelog
- MODULE.bazel
- Updated protobuf dependency from version 29.2 to 30.2 (line 41 -> 37).
- Removed the rules_apple dependency (lines 31-33).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A module's dependencies shift,
Old ones out, new ones a gift.
Protobuf ascends,
Rules_apple suspends,
Build's future, a hopeful lift.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the protobuf version and removes the rules_apple dependency. The changes seem straightforward, but it's important to verify the compatibility of the protobuf update and ensure that the removal of rules_apple doesn't break any existing functionality.
Summary of Findings
- Removal of rules_apple: The pull request removes the
rules_apple
dependency. It's important to ensure that this removal doesn't break any existing functionality that relies on these rules. Verify that there are no unintended consequences from this change. - Protobuf version update: The pull request updates the protobuf version from 29.2 to 30.2. It's crucial to ensure that this update is compatible with the rest of the codebase and doesn't introduce any breaking changes. Verify that all protobuf-related code still functions correctly after this update.
Merge Readiness
The pull request updates the protobuf version and removes the rules_apple dependency. Before merging, it's crucial to verify the compatibility of the protobuf update and ensure that the removal of rules_apple doesn't break any existing functionality. Given the potential for breaking changes, I recommend addressing the high severity comment before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
c8604ab
to
0cafb01
Compare
Relates to #1218.
Fails to build, see: