Recover hardcoded host in Go HTTP-client routes (v101) - #90
Merged
Conversation
A `baseURL + "/path"` client call discarded the host, so third-party API calls were counted as unresolved internal edges and flipped an isolated backend to a false coverage_gap. Resolve the base identifier through a package-scoped string-literal index and tag external/host when every binding is an absolute http(s) URL. Also match a client route against the server index before bucketing it external, so a route tagged external that targets a loaded internal host still resolves to its cross-repo edge. Bumps cacheVersion to v101; adds the go_httpclient_multirepo golden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
baseURL + "/path"client call discarded the host, so third-party API calls were counted as unresolved internal edges and flipped an isolated backend to a false coverage_gap. Resolve the base identifier through a package-scoped string-literal index and tag external/host when every binding is an absolute http(s) URL.Also match a client route against the server index before bucketing it external, so a route tagged external that targets a loaded internal host still resolves to its cross-repo edge.
Bumps cacheVersion to v101; adds the go_httpclient_multirepo golden.