fix(tsextractor): emit test_ref facts so test-only helpers aren't dea… - #93
Merged
Conversation
…d code TypeScript was the last language where a production symbol called only from its *.test.ts(x)/*.spec.ts(x) was reported dead under config.Default(). Close both gates: - add the four TS/TSX test globs to config.Default().TestGlobs - implement plugin.TestRefExtractor on tsextractor, reusing the production collectTSFileRefs walk/resolvers (fully-qualified targets, no bare-name over-crediting via orphans' lastSeg fold) Bump cacheVersion to v103 (tsextractor is a FileOwner) + cachecov entry; add ts_sample fixture and regenerate its golden. On golf-ui, test_ref goes 0 -> 9 and the src/app.sitemap dead-code false positive resolves, with no god-class/hotspots inflation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d code
TypeScript was the last language where a production symbol called only from its .test.ts(x)/.spec.ts(x) was reported dead under config.Default().
Close both gates:
Bump cacheVersion to v103 (tsextractor is a FileOwner) + cachecov entry; add ts_sample fixture and regenerate its golden. On golf-ui, test_ref goes 0 -> 9 and the src/app.sitemap dead-code false positive resolves, with no god-class/hotspots inflation.