Skip to content

Conversation

@anatol-sialitski
Copy link
Contributor

@anatol-sialitski anatol-sialitski linked an issue Nov 7, 2025 that may be closed by this pull request
private final List<FormItemJson> items;

public FormJson( final Form form, final LocaleMessageResolver localeMessageResolver, final InlineMixinResolver inlineMixinResolver )
public FormJson( final Form form, final LocaleMessageResolver localeMessageResolver, final CmsFormFragmentServiceResolver inlineMixinResolver )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Codacy found a minor CodeStyle issue: Line is longer than 140 characters (found 147).

The issue identified by the Checkstyle linter is that the line defining the constructor of the FormJson class exceeds the maximum allowed length of 140 characters, which can reduce code readability.

To fix this issue, we can break the constructor parameters into multiple lines. Here’s the suggested code change:

    public FormJson( final Form form, final LocaleMessageResolver localeMessageResolver, 
                     final CmsFormFragmentServiceResolver inlineMixinResolver )

This comment was generated by an experimental AI tool.


final ApplicationInfo applicationInfo = this.applicationInfoService.getApplicationInfo( applicationKey );
final Descriptors<WidgetDescriptor> widgetDescriptors = this.widgetDescriptorService.getByApplication( applicationKey );
final Descriptors<AdminExtensionDescriptor> extensionDescriptors = this.adminExtensionDescriptorService.getByApplication( applicationKey );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Codacy found a minor CodeStyle issue: Line is longer than 140 characters (found 147).

The issue reported by the Checkstyle linter indicates that the line of code exceeds the maximum allowed length of 140 characters, which can make the code harder to read and maintain. To resolve this, we can break the line into two separate lines while maintaining the clarity of the code.

Here's the suggested change:

        final Descriptors<AdminExtensionDescriptor> extensionDescriptors = 
            this.adminExtensionDescriptorService.getByApplication(applicationKey);

This comment was generated by an experimental AI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to the latest version of XP 8

2 participants