Enonic UI: Fix ProjectSelectionDialog sizing #9347 #9348
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#9347 Adjusted space between header and first item(is actually 43px from title to first item or 30px from close button to first item). Adjusted space from last item to bottom border of dialog 80px(40+40px) while maintaining list viewport. Replaced gap in list with padding to keep selector from "jumping" with space between items. Changed logic operator so text for create project / ask admin matches user rights(now says create project when project creation is available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted space between header and first item(is actually 43px from title to first item or 30px from close button to first item). Adjusted space from last item to bottom border of dialog 80px(40+40px) while maintaining list viewport. Replaced gap in list with padding to keep selector from "jumping" with space between items. Changed logic operator so text for create project / ask admin matches user rights(now says create project when project creation is available).
NOTE: on mobile devices there is strange behavior for scroll on x axis, this needs to be fixed from npm enonic ui, as items can't stretch properly when overflow on x axis is available. This results in selected items and hovered items getting a too "narrow" background.