Upgrade to the latest version of XP 8 #2427 #2428
Conversation
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| builder.inlineMixinResolver ) : null; | ||
| builder.cmsDescriptor != null && builder.cmsDescriptor.getForm() != null ? new FormJson( builder.cmsDescriptor.getForm(), | ||
| builder.localeMessageResolver, | ||
| builder.cmsFormFragmentServiceResolver ) : null; |
There was a problem hiding this comment.
ℹ️ Codacy found a minor CodeStyle issue: Line is longer than 140 characters (found 149).
The issue identified by the Checkstyle linter is that the line of code exceeds the maximum allowed length of 140 characters, making it difficult to read and maintain. To resolve this, we can break the line into two parts while maintaining the logical grouping of parameters.
Here's a code suggestion to fix the issue by splitting the line:
| builder.cmsFormFragmentServiceResolver ) : null; | |
| builder.cmsFormFragmentServiceResolver ) |
This comment was generated by an experimental AI tool.
|
|
||
|
|
||
| public FormJson( final Form form, final LocaleMessageResolver localeMessageResolver, final InlineMixinResolver inlineMixinResolver ) | ||
| public FormJson( final Form form, final LocaleMessageResolver localeMessageResolver, final CmsFormFragmentServiceResolver inlineMixinResolver ) |
There was a problem hiding this comment.
ℹ️ Codacy found a minor CodeStyle issue: Line is longer than 140 characters (found 147).
The issue reported by the Checkstyle linter indicates that the line defining the constructor for the FormJson class exceeds the maximum allowed length of 140 characters, which can make the code harder to read and maintain.
To address this issue, we can break the constructor parameters into multiple lines for better readability while keeping it within the character limit.
Here's the suggested code change:
public FormJson(final Form form, final LocaleMessageResolver localeMessageResolver,
final CmsFormFragmentServiceResolver inlineMixinResolver)This comment was generated by an experimental AI tool.
| propertyValue = this.localeMessageResolver.localizeMessage( attribute.getValue(), propertyValue ); | ||
| } | ||
| json.put( "@" + attribute.getKey(), attribute.getValue() ); | ||
| private Map<String, Object> toJson( final GenericValue property ) |
There was a problem hiding this comment.
Generic value can already return raw value perfectly serializable
| { | ||
| private final CmsFormFragmentService cmsFormFragmentService; | ||
|
|
||
| public CmsFormFragmentServiceResolver( final CmsFormFragmentService cmsFormFragmentService ) |
There was a problem hiding this comment.
Users app doesn't need to deal with fragments
No description provided.