Persisted schema

[anatol-sialitski]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 81.99673% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.47%. Comparing base (ba24979) to head (4886683).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...src/main/java/com/enonic/xp/util/GenericValue.java	54.66%	25 Missing and 9 partials ⚠️
...src/main/java/com/enonic/xp/form/FormFragment.java	61.29%	12 Missing ⚠️
.../src/main/java/com/enonic/xp/form/FormItemSet.java	40.00%	3 Missing and 3 partials ⚠️
.../com/enonic/xp/schema/content/ContentTypeName.java	33.33%	0 Missing and 4 partials ⚠️
...xtension/GetListAllowedAdminExtensionsHandler.java	86.36%	0 Missing and 3 partials ⚠️
...api/src/main/java/com/enonic/xp/form/FormItem.java	0.00%	3 Missing ⚠️
...n/java/com/enonic/xp/form/FormOptionSetOption.java	50.00%	3 Missing ⚠️
...ava/com/enonic/xp/inputtype/TextInputTypeBase.java	40.00%	0 Missing and 3 partials ⚠️
...a/com/enonic/xp/schema/mixin/MixinDescriptors.java	82.35%	3 Missing ⚠️
...src/main/java/com/enonic/xp/site/MixinOptions.java	50.00%	3 Missing ⚠️
... and 26 more

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11504      +/-   ##
============================================
- Coverage     86.60%   86.47%   -0.14%     
+ Complexity    19607    19442     -165     
============================================
  Files          2528     2562      +34     
  Lines         66628    65907     -721     
  Branches       5367     5205     -162     
============================================
- Hits          57702    56991     -711     
- Misses         6313     6345      +32     
+ Partials       2613     2571      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codacy-production]

⚠️ Codacy found a medium BestPractice issue: Avoid unused constructor parameters such as 'maximum'.

The issue reported by the PMD linter indicates that the constructor parameter maximum is not being used within the constructor body. This is considered a best practice violation because it can lead to confusion about the purpose of the parameter if it is not utilized.

To resolve this issue, we can remove the unused parameter from the constructor. Here’s the suggested change:

Suggested change

	public OccurrencesMapper( @JsonProperty("min") int minimum, @JsonProperty("max") int maximum )
	public OccurrencesMapper( @JsonProperty("min") int minimum )

---

This comment was generated by an experimental AI tool.

[codacy-production]

⚠️ Codacy found a medium Complexity issue: The method 'extractMetadata(MediaInfo)' has an NPath complexity of 288, current threshold is 200

The issue identified by the PMD linter relates to the NPath complexity of the extractMetadata method. NPath complexity measures the number of unique execution paths through a method, which can increase significantly with nested loops and conditionals. A high NPath complexity (like 288 in this case) indicates that the method is likely too complex, making it harder to understand, maintain, and test.

To address this complexity issue, one effective approach is to break the method into smaller, more manageable pieces. However, since you requested a single line change, we can focus on simplifying or refactoring a specific part of the method.

Given that the provided code fragment does not include the full implementation of the extractMetadata method, a common approach to reduce complexity is to extract the metadata processing logic into a separate method. However, since we are limited to a single line change, we can make a small adjustment to the existing code that might help reduce complexity slightly.

Here's a suggestion to encapsulate the metadata extraction logic within a helper method, which reduces the complexity by offloading some of the logic:

Suggested change

	private Mixins extractMetadata( final MediaInfo mediaInfo )
	private Mixins extractMetadata( final MediaInfo mediaInfo ) { return processMetadata(mediaInfo.getMetadata().asMap()); }

In this suggestion, processMetadata would be a new method that you would need to implement to handle the processing of the metadata. This change reduces the complexity of extractMetadata by delegating part of its logic to another method, making it easier to maintain and understand.

---

This comment was generated by an experimental AI tool.