Cluster race in patching #11503

[vbradnitski]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.60%. Comparing base (5e08d73) to head (b4d5920).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #11509      +/-   ##
============================================
- Coverage     86.60%   86.60%   -0.01%     
  Complexity    19607    19607              
============================================
  Files          2528     2528              
  Lines         66629    66628       -1     
  Branches       5367     5367              
============================================
- Hits          57703    57702       -1     
  Misses         6313     6313              
  Partials       2613     2613              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR addresses a cluster race condition in the patching mechanism by refactoring how patched node version data is tracked and reused. The key change is storing complete NodeVersionData objects instead of just metadata, eliminating an unnecessary and potentially problematic re-fetch operation.

• Refactored patchedVersions map to store NodeVersionData instead of NodeVersionMetadata
• Removed redundant node re-fetch operation in patchNodeInBranch that could cause race conditions
• Renamed nodeVersionMetadata parameter in NodeVersionData record to metadata for consistency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
NodeVersionData.java	Renamed record parameter from nodeVersionMetadata to metadata for brevity
PatchNodeCommand.java	Changed patched versions tracking from metadata-only to full node data, eliminating re-fetch
ApplyNodePermissionsCommand.java	Updated references to use renamed metadata() accessor method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.