-
Notifications
You must be signed in to change notification settings - Fork 34
Review Guide
Sten Roger Sandvik edited this page Jun 12, 2015
·
1 revision
In this guide we have written a checklist of what you should be looking at as an reviewer of code.
Some libraries (that we have on the classpath) should be avoided if possible.
- Apache Commons Lang
-
org.apache.commons.lang(try to usecom.google.guavaclasses instead)
-
- Apache Commons IO
-
org.apache.commons.io(try to usecom.google.guavaclasses instead)
-
Look out for deprecated 3rd party API usages. We should avoid using deprecated methods and classes if it can be avoided. Here's a list of some wide used deprecated classes/methods that must be avoided:
-
junit.framework.Assert(useorg.junit.Assert)