Remove zoomed condition from Timeline animation reset logic - #13
Merged
Conversation
The overlap detection that flips info cards above the timeline was being skipped entirely in zoom mode. This caused events sharing the same date to render both cards below the line, overlapping each other. Remove the zoomed guard so the existing overlap algorithm runs in zoom mode too — it already handles the layout correctly by measuring actual DOM positions. https://claude.ai/code/session_01JRsr7z5g81APXYnjDmhNW6
|
🔗 Deploy preview: https://69dba8c3c6dbb48306f92395--closerintimewiki.netlify.app |
Previously overlap detection was skipped entirely on mobile, causing same-date events to render their info cards on top of each other. Now the layout effect runs a vertical variant of the algorithm that checks top/bottom overlap instead of left/right. Overlapping cards are flipped to the LEFT side of the timeline, mirroring the desktop behavior of flipping above the line. The CSS for .markerInfoFlipped on mobile is updated to absolutely position the card to the left of the marker circle, fitting within the existing 20vw left margin of the timeline. https://claude.ai/code/session_01JRsr7z5g81APXYnjDmhNW6
|
🔗 Deploy preview: https://69dbb4055b22dba638037e40--closerintimewiki.netlify.app |
Instead of moving the flipped info card to the left side of the timeline, keep it on the right side but offset it downward by the marker circle height so both cards are visible and stacked. https://claude.ai/code/session_01JRsr7z5g81APXYnjDmhNW6
|
🔗 Deploy preview: https://69dbb5ee02f84279593dcc62--closerintimewiki.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the condition that determines when to reset flipped keys in the AnimatedTimeline component by removing the
zoomedstate check.Key Changes
zoomedfrom the conditional logic that triggers flipped keys resetImplementation Details
The condition on line 103 was changed from
if (isVertical || exit || zoomed)toif (isVertical || exit). This means the flipped keys will no longer be automatically cleared when the timeline is in a zoomed state, allowing zoom interactions to maintain their animation state independently.https://claude.ai/code/session_01JRsr7z5g81APXYnjDmhNW6