[mob][photos] Fix incorrect file deletion from db when widget unmounts during thumbnail loading #7007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding Previously, when _loadWithRetry returned null due to widget unmounting, the code incorrectly assumed the local file was deleted and would remove database references or delete the file. This could lead to data loss. Changes: - Add new WidgetUnmountedException to centralized exceptions.dart for reuse - Throw WidgetUnmountedException instead of returning null when widget unmounts - Handle WidgetUnmountedException separately in error handler with appropriate logging - Still set _errorLoadingLocalThumbnail flag to prevent retry attempts Using Exception instead of Error follows Dart conventions: - Exceptions are for recoverable runtime conditions (like widget unmounting) - Errors are for programming mistakes that shouldn't be caught This ensures that widget unmounting is properly distinguished from actual file access failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ua741
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when _loadWithRetry returned null due to widget unmounting, the code incorrectly assumed the local file was deleted and would remove database reference of the file and which would trigger re-upload of the file.