[mob][photos] fix manual video streaming when ML is enabled #7009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ML is enabled but not running, the compute controller blocks all stream requests due to _waitingToRunML flag. This prevents users from manually creating video streams even though ML isn't actively using resources. Add bypassMLWaiting parameter to allow manual stream creation to proceed regardless of ML waiting state, improving UX.
When users click "Create Stream" on files already in queue from previous sessions, ensure processing actually starts even if the file was previously stalled due to ML blocking. Add forceProcess parameter to queueFiles() to bypass the existing queue check and trigger processing of stalled manual queue items.
ua741
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When ML is enabled, the ComputeController blocks all stream requests when
_waitingToRunMLis true, even for manual user-initiated streams. Additionally, if files were queued in previous sessions but never processed, clicking "Create Stream" again would just show "already in queue" without actually triggering processing.Solution
bypassMLWaitingparameter to allow manual streams to proceed regardless of ML waiting stateforceProcessparameter toqueueFiles()to trigger processing of already-queued files that may have been stalledTest plan