-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[server] Like and Comment #8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d13a4e to
5124747
Compare
a24fc97 to
b9f0000
Compare
| if cleanupErr := c.removeUserSocialActivity(ctx, shareCollection.CollectionID, shareCollection.ToUserID); cleanupErr != nil { | ||
| return cleanupErr | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test this flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f21c77c728
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if reaction.AnonUserID == nil || req.Actor.AnonUserID == nil || *reaction.AnonUserID != *req.Actor.AnonUserID { | ||
| return stacktrace.Propagate(ente.ErrPermissionDenied, "") | ||
| } | ||
| } else if !hasUserID || reaction.UserID != userID { | ||
| return stacktrace.Propagate(ente.ErrPermissionDenied, "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow admins to moderate reactions
Reactions can only be deleted by the original actor (reaction.AnonUserID/reaction.UserID must match the caller), and there is no admin override even when RequireAccess is true. That means collection owners or admins cannot remove abusive reactions left by other users or anonymous visitors on their public/shared collections, unlike comments which explicitly allow moderation. Once a bad reaction is posted, it becomes undeletable by the collection owner.
Useful? React with 👍 / 👎.
Description
Tests