Skip to content

Conversation

@neeraj-pilot
Copy link
Contributor

Description

Tests

@ua741 ua741 marked this pull request as ready for review January 5, 2026 12:13
Comment on lines +221 to 224
if cleanupErr := c.removeUserSocialActivity(ctx, shareCollection.CollectionID, shareCollection.ToUserID); cleanupErr != nil {
return cleanupErr
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test this flow

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f21c77c728

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +150 to +154
if reaction.AnonUserID == nil || req.Actor.AnonUserID == nil || *reaction.AnonUserID != *req.Actor.AnonUserID {
return stacktrace.Propagate(ente.ErrPermissionDenied, "")
}
} else if !hasUserID || reaction.UserID != userID {
return stacktrace.Propagate(ente.ErrPermissionDenied, "")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow admins to moderate reactions

Reactions can only be deleted by the original actor (reaction.AnonUserID/reaction.UserID must match the caller), and there is no admin override even when RequireAccess is true. That means collection owners or admins cannot remove abusive reactions left by other users or anonymous visitors on their public/shared collections, unlike comments which explicitly allow moderation. Once a bad reaction is posted, it becomes undeletable by the collection owner.

Useful? React with 👍 / 👎.

@ua741 ua741 requested a review from mnvr January 6, 2026 05:10
@ua741 ua741 enabled auto-merge January 6, 2026 05:17
@ua741 ua741 merged commit 4e5ea99 into ente-io:main Jan 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants