Skip to content

Conversation

@neeraj-pilot
Copy link
Contributor

Summary

  • Show all albums in horizontal scroll (remove 3-album limit)
  • Use CollectionListPage for "View all" with search, sort, and layout options
  • Enable bulk selection with Unarchive/Unhide and Delete actions
  • Delete unused AllAlbumsPage

Test plan

  • Archive: verify horizontal scroll, View all with search/sort/layout, bulk select with Unarchive/Delete
  • Hidden: same as above, verify albums open correctly after unlock

@ua741 ua741 changed the title Improve archive and hidden albums section [mob][photos] Improve archive and hidden albums section Jan 5, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c7a2dd947

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 275 to 276
} else if (widget.sectionType == UISectionType.hiddenCollections) {
collections = CollectionsService.instance.getHiddenCollections();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude default hidden collection when refreshing list

In the hidden collections section, refreshCollections() now reloads from CollectionsService.getHiddenCollections() without includeDefaultHidden: false, so any refresh (search typing or collection update event) will repopulate the list with the default hidden collection that HiddenPage intentionally filters out. This makes the internal default hidden album appear in “View all” after a refresh, which is inconsistent with the hidden list elsewhere (e.g., HiddenPage and collection_action_sheet explicitly exclude it). Consider filtering the default hidden collection here as well.

Useful? React with 👍 / 👎.

@neeraj-pilot neeraj-pilot force-pushed the fixArchivedHiddenAlbums branch from 0c7a2dd to e736a64 Compare January 5, 2026 08:10
@ua741 ua741 merged commit 8742c85 into ente-io:main Jan 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants