-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[mob][photos] Social #8616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mob][photos] Social #8616
Conversation
Co-Authored-By: Claude <[email protected]>
…on on file's bottom bar and get like button working
Co-Authored-By: Claude <[email protected]>
Add ValueKey to CommentBubbleWidget and didUpdateWidget override to prevent stale parent comment data when ListView recycles State objects. Co-Authored-By: Claude <[email protected]>
…idgets instead of helper functions that return widget
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Add OverlayPortal with dark barrier on long-press - Show highlighted comment with Like/Reply popup menu - Use GlobalKey to capture exact widget size for alignment - Hide inline action capsule when overlay is shown 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Move CommentActionsPopup into _buildCommentContent - Remove Material wrapper blocking hit tests outside comment 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…e it is outside it's parent
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…g press) and unselecting (tap outside) it
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Keep model defaults as false. New links get comments enabled via explicit API parameter in createShareUrl. Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Store shared collection status in state instead of using FutureBuilder. This ensures social icons are only added to the Row when the file is actually in a shared collection, fixing the spaceAround layout issue where icons appeared on the left half due to invisible SizedBox.shrink widgets still occupying layout slots. Co-Authored-By: Claude <[email protected]>
## Description ## Tests
When a file is in a shared collection, the like and comment buttons are displayed in the bottom bar. To avoid overcrowding, the Add to Album button is now moved to the app bar popup menu in this case. Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a23fec3e78
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-Authored-By: Claude <[email protected]>
Rethrow exceptions from SocialDataProvider instead of returning null, and add try-catch with toast feedback and UI rollback in all social interaction points (like, unlike, send comment, delete comment). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Description
Comment and like on photos/videos in shared albums.