Updated workflows #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflows to streamline automation for CI/CD and release management. Key changes include adding a new release workflow, updating branch triggers in multiple workflows, and upgrading the golangci-lint action while removing an explicit test arguments configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/license_go.yml | Added branch trigger for master alongside main |
| .github/workflows/go.yml | Added master branch trigger, upgraded golangci-lint action, and removed explicit test arguments |
| .github/workflows/changelog.yml | Added a new release workflow to automate changelog generation and GitHub release creation |
Comments suppressed due to low confidence (2)
.github/workflows/go.yml:61
- [nitpick] Consider adding a comment explaining the removal of the explicit testArguments configuration to clarify that this change is intentional and to inform future maintainers.
- with:
- testArguments: ./...
.github/workflows/go.yml:36
- The upgrade to golangci-lint-action@v8 may bring breaking changes compared to v6; please verify the updated configuration and linting options against the action's documentation.
uses: golangci/golangci-lint-action@v8
ktaganova
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across workflow configurations and Go code. Key changes include the addition of a new GitHub Actions workflow for automated releases, updates to existing workflows for broader compatibility and tool upgrades, and enhanced error handling in Go functions.
Workflow Enhancements:
.github/workflows/changelog.ymlworkflow to automate GitHub releases. This workflow triggers on version tags, generates a changelog, and creates a release usingmikepenz/release-changelog-builder-actionandsoftprops/action-gh-release..github/workflows/go.ymland.github/workflows/license_go.ymlto include themasterbranch as a trigger for workflows, in addition tomain. [1] [2]golangci-lint-actionin.github/workflows/go.ymlfrom versionv6tov8for improved linting capabilities.testArguments: ./...configuration from thego-test-actionin.github/workflows/go.yml, simplifying the test job setup.Go Code Improvements:
itscope.goby ensuring that errors fromresponse.Body.Close()are captured and propagated in theGetAllProductTypesandGetProductsFromQueryfunctions. [1] [2]