fix(chat): TTS Manager never stops after upstream errors#5
Merged
Conversation
entitycs
commented
Jun 18, 2026
Owner
Author
There was a problem hiding this comment.
-
streamingTTS, _isAgent changed from const to let.
- No negative implications unless code ownership is implied
-
streamingTTS could still end up undefined
- but at least some reason as to why can hit the logs
Is there a more standardized logging system to use?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses error: "ReferenceError: streamingTTS is not defined". Catches (2) closely aligned bugs in the same scope.
Alternate title (not far-reaching, promise): "fix(chat): Fix undefined variable bugs leading to uncaught exceptions in error-handling logic"
TTS Manager fails to reach an expected lifecycle state -- never stops or ends stream on upstream errors which throw within the scoped context in which the streamingTTS variable lives (lived). This fix addresses that error, along with two bugs serving as the cause of 2 additional repeat errors in the same scope.
Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Part of odysseus-dev#3603 (Issue 1 of 2)
Part of odysseus-dev#3681 (May fix odysseus-dev#3603, Issue 2 of 2, but only avoids the bug actually causing Issue 1 - this fixes the bug which causes that slice of the issue)
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
python -m pytestVisual / UI changes — REQUIRED if you touched anything that renders
Anything that changes what the UI looks like — buttons, icons, padding, colors, fonts, spacing, layout, CSS, HTML, SVG, or any
static/js/module that draws to the DOM — needs all of the following. PRs that change rendering without these WILL be closed.--red,--fg,--bg,--card,--border, etc.) — do not introduce new color values, font sizes, or spacing units.static/index.html) or plain text.Fira Code) for primary UI text. Don't override.Screenshots / clips