Skip to content

Comments

Draft new geofencing zones api#761

Draft
testower wants to merge 1 commit intomasterfrom
feature/geofencing_zones_global_rules
Draft

Draft new geofencing zones api#761
testower wants to merge 1 commit intomasterfrom
feature/geofencing_zones_global_rules

Conversation

@testower
Copy link
Collaborator

@testower testower commented Sep 15, 2025

PR Instructions

When creating a pull request, please follow the format below. For each section, replace the
guidance text with your own text, keeping the section heading. If you have nothing to say in a
particular section, you can completely delete the section including its heading to indicate that you
have taken the requested steps. None of these instructions or the guidance text (non-heading text)
should be present in the submitted PR. These sections serve as a checklist: when you have replaced
or deleted all of them, the PR is considered complete.

Summary

Closes #758

Unit tests

Write a few words on how the new code is tested.

  • Were unit tests added/updated?
  • Was any manual verification done?
  • Any observations on changes to performance?
  • Was the code designed so it is unit testable?
  • Were any tests applied to the smallest appropriate unit?

Documentation

  • Have you added documentation in code covering design and rationale behind the code?
  • Were all non-trivial public classes and methods documented with Javadoc?
  • Were any new configuration options added?

Changelog

The changelog file
is generated from the pull-request title, make sure the title describe the feature or issue fixed.
To exclude the PR from the changelog add the label skip changelog to the PR.

Bumping the serialization version id

If you have made changes to the way the routing graph is serialized, for example by renaming a field
in one of the edges, then you must add the label bump serialization id to the PR. With this label
Github Actions will increase the field lamassu.serialization.version.id in pom.xml.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.87%. Comparing base (f191eed) to head (094d4f9).

Files with missing lines Patch % Lines
...mapper/entitymapper/GeofencingZonesDataMapper.java 81.48% 5 Missing and 10 partials ⚠️
...ur/lamassu/model/entities/GeofencingZonesData.java 74.07% 7 Missing ⚠️
.../graphql/query/GeofencingZonesQueryController.java 20.00% 4 Missing ⚠️
...u/leader/entityupdater/GeofencingZonesUpdater.java 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #761      +/-   ##
============================================
- Coverage     81.97%   81.87%   -0.10%     
- Complexity     1445     1473      +28     
============================================
  Files           196      199       +3     
  Lines          5347     5469     +122     
  Branches        346      356      +10     
============================================
+ Hits           4383     4478      +95     
- Misses          750      766      +16     
- Partials        214      225      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support global_rules from geofencing_zones.json

1 participant