Skip to content

Adds ScheduledStopPointRef->FlexibleStopPointRef map to common data repo #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

erlendev
Copy link
Contributor

@erlendev erlendev commented Apr 7, 2025

No description provided.

@erlendev erlendev requested a review from vpaturet April 7, 2025 11:05
erlendev added 2 commits April 8, 2025 10:21
Ensures we support scheduled stop place -> flexible stop place mapping not only through having the mapping in CommonDataRepository, but also through the NetexEntitiesIndex of JAXBValidationContext.

The mapping from NetexEntitiesIndex takes precedence over the one from CommonDataRepository.
Copy link
Collaborator

@vpaturet vpaturet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since you add a method to an existing interface without providing a default implementation, you introduce a breaking change. So the version number should be bumped from 9.x to 10.x

@erlendev erlendev closed this Apr 9, 2025
@erlendev erlendev reopened this Apr 9, 2025
Copy link

sonarqubecloud bot commented Apr 9, 2025

@erlendev erlendev merged commit 308e717 into main Apr 9, 2025
3 checks passed
@erlendev erlendev deleted the flexible-stop-place-ref-cache branch April 9, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants