Be more explicit about hitting the Stop button when headed in the wrong direction. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanlabouve
reviewed
May 14, 2018
| @@ -44,6 +44,7 @@ Tactically, it can & maybe should cover: | |||
| ### We act like owners and keep context | |||
| * We love engineering and technology, but we solve for our customers and the bigger teams 1st. | |||
| * If we can’t unanimously articulate why we’re doing something, we don’t do it. | |||
| * If we have a nagging suspician we're headed in the wrong direction, we hit the Stop button, raise the issue, and rethink. | |||
There was a problem hiding this comment.
The capitalization on Stop button feels weird. Can we either enclose in quotes or capitalize Button as well?
|
Sorry @raelity! I renamed |
mattharris5
suggested changes
May 22, 2018
| @@ -44,6 +44,7 @@ Tactically, it can & maybe should cover: | |||
| ### We act like owners and keep context | |||
| * We love engineering and technology, but we solve for our customers and the bigger teams 1st. | |||
| * If we can’t unanimously articulate why we’re doing something, we don’t do it. | |||
| * If we have a nagging suspician we're headed in the wrong direction, we hit the Stop button, raise the issue, and rethink. | |||
There was a problem hiding this comment.
suspicion is misspelled but otherwise this is a great addition. (I'm fine with the capitalized Button too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.