Skip to content

Conversation

@Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Aug 11, 2025

Description

This PR is to add v1 inferencepool support

Related Issues/PRs (if applicable)

Fixes #1032

@mathetake
Copy link
Member

mathetake commented Aug 11, 2025

I won't review until the upstream API PR lands: kubernetes-sigs/gateway-api-inference-extension#1173

@Xunzhuo Xunzhuo marked this pull request as draft August 11, 2025 06:17
@johnugeorge
Copy link
Contributor

Can we plan this effort in the next work?

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Sep 18, 2025

@johnugeorge sure, will schedule sometime to finish this next week

@Xunzhuo Xunzhuo self-assigned this Sep 18, 2025
@mathetake
Copy link
Member

after this lands, we should raise a PR to https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/conformance/reports/v1.0.0/gateway

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Sep 19, 2025

Yes for sure

@mathetake
Copy link
Member

@Xunzhuo kindly ping

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Sep 28, 2025

will redo this PR after #1239

@mathetake
Copy link
Member

ping @Xunzhuo

@mathetake mathetake added this to the v0.4.0 milestone Oct 7, 2025
@mathetake
Copy link
Member

@Xunzhuo resolved the huge conflicts for you! I think it should be good to go

@Xunzhuo
Copy link
Member Author

Xunzhuo commented Oct 10, 2025

what! cool @mathetake haha, i was scheduling to resolve this at this week, but if it is good to go, let us move this forward

Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Copy link
Member

ah i think the documentation change also needed

Signed-off-by: bitliu <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.56%. Comparing base (e3bf5fd) to head (501ff19).

Files with missing lines Patch % Lines
tests/internal/e2elib/e2elib.go 0.00% 3 Missing ⚠️

❌ Your project status has failed because the head coverage (77.56%) is below the target coverage (86.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1033   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         123      123           
  Lines       15768    15759    -9     
=======================================
- Hits        12230    12224    -6     
+ Misses       2908     2906    -2     
+ Partials      630      629    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo marked this pull request as ready for review October 10, 2025 09:07
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
Signed-off-by: bitliu <[email protected]>
@Xunzhuo Xunzhuo requested a review from mathetake October 10, 2025 11:27
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Oct 10, 2025

i think this is good to go, the ext-proc e2e is not related to this PR(broken by mcp tests)

Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake enabled auto-merge (squash) October 10, 2025 15:15
@mathetake mathetake disabled auto-merge October 10, 2025 15:23
@mathetake mathetake merged commit 7e2e42a into envoyproxy:main Oct 10, 2025
27 of 28 checks passed
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
**Description**

This PR is to add v1 inferencepool support

**Related Issues/PRs (if applicable)**

Fixes envoyproxy#1032

---------

Signed-off-by: bitliu <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Hrushikesh Patil <[email protected]>
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
**Description**

This PR is to add v1 inferencepool support

**Related Issues/PRs (if applicable)**

Fixes envoyproxy#1032

---------

Signed-off-by: bitliu <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Hrushikesh Patil <[email protected]>
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
**Description**

This PR is to add v1 inferencepool support

**Related Issues/PRs (if applicable)**

Fixes envoyproxy#1032

---------

Signed-off-by: bitliu <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Hrushikesh Patil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Gateway Inference Extension's V1 InferencePool

4 participants