-
Notifications
You must be signed in to change notification settings - Fork 119
chore: updates to Go 1.25 and refactors some code #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
+ Coverage 78.33% 78.67% +0.34%
==========================================
Files 86 86
Lines 9808 9805 -3
==========================================
+ Hits 7683 7714 +31
+ Misses 1757 1723 -34
Partials 368 368 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In case you find it useful: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize |
Signed-off-by: Adrian Cole <[email protected]>
|
@gonzaloserrano thanks a lot! added! (except json tag changes) Note it seems coverage changed a bit hence we're not hitting targets like before.. |
Signed-off-by: Adrian Cole <[email protected]>
|
I will try to vibe some coverage to get us over the line |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
|
looking cool... the discussion was that we will start using 1.25 after v0.3 which will happen within a few days 🤞 |
|
cool as I'm out of time vibing for the next few days anyway ;) |
Signed-off-by: Takeshi Yoneda <[email protected]>
|
oh wow, thanks for merging ;) |
Description
This updates to Go 1.25 and uses some new features.
See https://tip.golang.org/doc/go1.25