Skip to content

Conversation

@codefromthecrypt
Copy link
Contributor

Description

This updates to Go 1.25 and uses some new features.

See https://tip.golang.org/doc/go1.25

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.67%. Comparing base (e74bb3f) to head (5149b2f).

Files with missing lines Patch % Lines
tests/internal/testenvironment/test_environment.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   78.33%   78.67%   +0.34%     
==========================================
  Files          86       86              
  Lines        9808     9805       -3     
==========================================
+ Hits         7683     7714      +31     
+ Misses       1757     1723      -34     
  Partials      368      368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gonzaloserrano
Copy link

In case you find it useful: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Aug 14, 2025

@gonzaloserrano thanks a lot! added! (except json tag changes)

Note it seems coverage changed a bit hence we're not hitting targets like before..

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Contributor Author

I will try to vibe some coverage to get us over the line

Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
@mathetake mathetake added this to the v0.4.0 milestone Aug 14, 2025
@mathetake
Copy link
Member

looking cool... the discussion was that we will start using 1.25 after v0.3 which will happen within a few days 🤞

@codefromthecrypt
Copy link
Contributor Author

cool as I'm out of time vibing for the next few days anyway ;)

Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake marked this pull request as ready for review August 23, 2025 16:51
@mathetake mathetake requested a review from a team as a code owner August 23, 2025 16:51
@mathetake mathetake merged commit adfa081 into envoyproxy:main Aug 23, 2025
26 checks passed
@codefromthecrypt
Copy link
Contributor Author

oh wow, thanks for merging ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants