chore: support hostname in aigateway route#1987
Open
xianml wants to merge 1 commit intoenvoyproxy:mainfrom
Open
chore: support hostname in aigateway route#1987xianml wants to merge 1 commit intoenvoyproxy:mainfrom
xianml wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
|
Related Documentation 3 document(s) may need updating based on files changed in this PR: Envoy's Space aigatewayroute-inferencepool
|
34f8cfe to
7326736
Compare
Signed-off-by: xianml <xian@bentoml.com>
7326736 to
eb4ac51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, aigetewayroute seems act as cluster level CR, since it did not have a hostname attached to it. It means that we can not specific a group of models under a specific Hostname (say xx.api.aieg.com). And meanwhile, /v1/models will return all the openai models of all aigetewayroute CRs in the cluster.
Related Issues/PRs (if applicable)
Special notes for reviewers (if applicable)
mentioned in #1646