fix: convert reasoning_content to plain string in non‑streaming Gemini#1991
Open
KaveeshKhattar wants to merge 1 commit intoenvoyproxy:mainfrom
Open
fix: convert reasoning_content to plain string in non‑streaming Gemini#1991KaveeshKhattar wants to merge 1 commit intoenvoyproxy:mainfrom
KaveeshKhattar wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
1ff0e1b to
4451a3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
==========================================
+ Coverage 84.33% 84.47% +0.13%
==========================================
Files 130 130
Lines 17987 17953 -34
==========================================
- Hits 15170 15165 -5
+ Misses 1873 1847 -26
+ Partials 944 941 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…i responses Signed-off-by: Kaveesh Khattar <kaveeshkhattar@gmail.com>
4451a3e to
22b701d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-streaming Gemini responses were returning
reasoning_contentas a nested object instead of a plain string. This breaks OpenAI-compatible clients.This commit replaces the nested
awsbedrock.ReasoningContentBlockwith a direct string assignment for the reasoning content.Related Issues/PRs
Fixes #1974
Validation
TestGeminiCandidatesToOpenAIChoices_ReasoningContentto verify the change.make testandmake precommitpassed locally.Notes
Please suggest if signatures need to be handled differently.