[WIP] ci: Re-enable clang-tidy #29257
Conversation
phlax
force-pushed
the
clang-tidy-again
branch
from
3b81fbc to
55e213e
Compare
phlax
force-pushed
the
clang-tidy-again
branch
2 times, most recently
from
e958624 to
69afecd
Compare
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
This is still marked as draft, so I assume it's not yet ready for review. When it is ready for review, please update the PR description to explain what is changing beyond simply uncommenting what was commented out in #28569
phlax
force-pushed
the
clang-tidy-again
branch
10 times, most recently
from
5b87322 to
b3355f2
Compare
|
fwiw its not realistic to add clang-tidy as a precheck/hook/etc as i had hoped as it actually compiles stuff to run so can be expensive if there are a lot of changes this PR does decouple it from generating compdb tho which is good - and it makes use of bazels caching/expiry to test the correct things on change probs i should add compdb generation as a separate check - im looking at bazelifying that also |
phlax
force-pushed
the
clang-tidy-again
branch
8 times, most recently
from
09988d2 to
315ac59
Compare
ci/do_ci.sh
Outdated
| fi | ||
| exit 1 | ||
| } | ||
| CLANG_TIDY_TARGETS=( |
phlax
force-pushed
the
clang-tidy-again
branch
2 times, most recently
from
ac9b6dc to
345d057
Compare
phlax
force-pushed
the
clang-tidy-again
branch
7 times, most recently
from
3de9f28 to
395d749
Compare
|
Hi @phlax -- I'm curious how far (roughly) this is before landing. Thanks! |
not far off (for the fixes at least) - down to the last couple of errors/warnings last ci run is here https://dev.azure.com/cncf/envoy/_build/results?buildId=162153&view=logs&j=b7634614-24f3-5416-e791-4f3affaaed6c&t=2977bca8-7d96-53cb-e518-b36532847421&l=159 i have a pending diff with some more fixes |
phlax
force-pushed
the
clang-tidy-again
branch
2 times, most recently
from
5548e49 to
1815000
Compare
|
@jmarantz i have resolutions for ~all the current clang-tidy problems - im going to break out the fixes to a separate PR - they need to be checked fairly thoroughly wrt the CI part of this PR - running this repeatedly in CI and the perf is not too bad if not totally optimal - so probably we can just add it back as a check that runs in prs/commits as usual the one blocker is that i hacked the upstream that i forked to continue on error - not sure if i did that the best way but either way we need it to record and raise any errors at the end (of running the bazel aspect) - ill look further at this shortly |
phlax
force-pushed
the
clang-tidy-again
branch
2 times, most recently
from
87f748a to
bcf059d
Compare
phlax
force-pushed
the
clang-tidy-again
branch
2 times, most recently
from
aa9c2c5 to
2f182fa
Compare
phlax
force-pushed
the
clang-tidy-again
branch
4 times, most recently
from
8cfc83e to
a03630c
Compare
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
This reverts commit 17b1688. Signed-off-by: Ryan Northey <[email protected]>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]