googletest: upgrade to a newer version #33219
Conversation
Signed-off-by: Adi Suissa-Peleg <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
| # see https://github.com/google/googletest/issues/2490 | ||
| version = "a4ab0abb93620ce26efad9de9296b73b16e88588", | ||
| sha256 = "7897bfaa5ad39a479177cfb5c3ce010184dbaee22a7c3727b212282871918751", | ||
| version = "7e33b6a1c497ced1e98fc60175aeb4678419281c", |
There was a problem hiding this comment.
can we pin to a release version please?
There was a problem hiding this comment.
1.14.0 is the latest - https://github.com/google/googletest/releases/tag/v1.14.0
There was a problem hiding this comment.
We can pin to a release version, but unfortunately not the latest (requires new absl and protobuf versions).
| @@ -77,6 +77,11 @@ bool isDeathTestChild(int argc, char** argv) { | |||
|
|
|||
| int TestRunner::runTests(int argc, char** argv) { | |||
| const bool is_death_test_child = isDeathTestChild(argc, argv); | |||
|
|
|||
| // Use the recommended, but not default, "threadsafe" style for the Death Tests. | |||
There was a problem hiding this comment.
this comment (ie the original) is not entirely accurate
the threadsafe mode is not default (or recommended) as it makes testing much slower - not sure if we can do anything about that, so perhaps this is a pedantic point - but if there was a way not to do this it would be better
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
@adisuissa wondering what the blocker was on this - and thinking to |
Apologies, as I didn't have enough bandwidth to follow up on this. |
phlax
added
no stalebot
Commit Message: googletest: upgrade to a newer version
Additional Description:
Upgrading googletest dependency to a newer version (3 years forward).
After this upgrade, to set Envoy's CLI arguments in tests requires passing them after "--".
For example:
bazel test //test/common/common:logger_test --test_arg="--" --test_arg="-l trace"Risk Level: low - tests only
Testing: Updates
Docs Changes:
Release Notes: N/A
Platform Specific Features: N/A