Skip to content

Print disk usage information in ci logs #36701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

asedeno
Copy link
Contributor

@asedeno asedeno commented Oct 19, 2024

Risk Level: low
Testing: ci-workflow change

This lets us see this information without downloading an artifact.

Signed-off-by: Alejandro R. Sedeño <[email protected]>
@phlax phlax self-assigned this Oct 21, 2024
@phlax
Copy link
Member

phlax commented Oct 21, 2024

@asedeno we have only just removed this in favour of printing to a report json artifact for each job - i think we dont want to add it back

any reason you cant use the json report?

@asedeno
Copy link
Contributor Author

asedeno commented Oct 21, 2024

Why not both? An artifact is nice, but seeing an entry in the logs that say it's capturing free disk information and then not finding said information in the logs right there was very confusing.

@phlax
Copy link
Member

phlax commented Oct 21, 2024

Why not both?

its rare that you need this information and distracting when you are trying to figure out what broke

same argument could be made for the du debugging (as well as others)

@asedeno
Copy link
Contributor Author

asedeno commented Oct 21, 2024

And yet, I ran into a full disk in #36699 and was very confused by this information being collected and not presented to me. Downloading a zip file, unpacking a json artifact, and pretty printing it to see something that could have just been in the logs felt like needless busywork for something that could have just been printed.

@phlax
Copy link
Member

phlax commented Oct 21, 2024

And yet, I ran into a full disk in #36699 and was very confused by this information being collected and not presented to me. Downloading a zip file, unpacking a json artifact, and pretty printing it to see something that could have just been in the logs felt like needless busywork for something that could have just been printed.

perhaps this can be resolved with some dev documentation - as explained offline this really doesnt give you any of the information you require to resolve - just a confirmation of what you already know

the download and unzip step is perhaps a little convoluted but tbh is pretty trivial with the help of jq - ive been doing it frequently while debugging the migration

@phlax
Copy link
Member

phlax commented Oct 21, 2024

... and the ci-report does give you the info you need

@asedeno
Copy link
Contributor Author

asedeno commented Oct 21, 2024

I still think that this is useful information to print, but based on offline conversation, I'm closing this for now.

@asedeno asedeno closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants