-
Notifications
You must be signed in to change notification settings - Fork 4.9k
deps: upgrade rules_rust to v0.60 #39216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Takeshi Yoneda <[email protected]>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the PPC patch no longer required? Not sure about the lock file changes but with the release date change the deps look OK.
version = "0.60.0", | ||
sha256 = "7825214ccad7c2482cb490ac91dbc1e88b30223062796ce328aca893b74ae342", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires release date change release_date = "2025-08-08",
@moderation @mathetake I can confirm that the PPC patch is no longer necessary. |
yeah thank you for confirming. i am keeping this draft just because i haven't gotten around to fixing the failure, not relevant to PPC |
I think this will fail
closes #38725