Skip to content

deps: upgrade rules_rust to v0.60 #39216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Apr 23, 2025

I think this will fail

closes #38725

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #39216 was opened by mathetake.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 23, 2025
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #39216 was opened by mathetake.

see: more, trace.

@mathetake
Copy link
Member Author

ERROR: /build/bazel_root/base/external/rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools/BUILD.bazel:97:15: in rust_toolchain rule @@rust_linux_x86_64__x86_64-unknown-linux-gnu__stable_tools//:rust_toolchain: 
Traceback (most recent call last):
	File "/build/bazel_root/base/external/rules_rust/rust/toolchain.bzl", line 672, column 72, in _rust_toolchain_impl
		libstd_and_allocator_ccinfo = _make_libstd_and_allocator_ccinfo(ctx, rust_std, ctx.attr.allocator_library, "std"),
	File "/build/bazel_root/base/external/rules_rust/rust/toolchain.bzl", line 161, column 60, in _make_libstd_and_allocator_ccinfo
		cc_toolchain, feature_configuration = find_cc_toolchain(ctx)
	File "/build/bazel_root/base/external/rules_rust/rust/private/utils.bzl", line 57, column 43, in find_cc_toolchain
		cc_toolchain = find_rules_cc_toolchain(ctx)
	File "/build/bazel_root/base/external/rules_cc/cc/find_cc_toolchain.bzl", line 101, column 9, in find_cc_toolchain
		fail("In order to use find_cc_toolchain, your rule has to depend on C++ toolchain. See find_cc_toolchain.bzl docs for details.")
Error in fail: In order to use find_cc_toolchain, your rule has to depend on C++ toolchain. See find_cc_toolchain.bzl docs for details.

Copy link
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the PPC patch no longer required? Not sure about the lock file changes but with the release date change the deps look OK.

Comment on lines +1447 to +1448
version = "0.60.0",
sha256 = "7825214ccad7c2482cb490ac91dbc1e88b30223062796ce328aca893b74ae342",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires release date change release_date = "2025-08-08",

@Jenkins-J
Copy link
Contributor

@moderation @mathetake I can confirm that the PPC patch is no longer necessary.
The PPC changes were merged upstream into rules_rust and released with rules_rust version 0.59.1.

@mathetake
Copy link
Member Author

yeah thank you for confirming. i am keeping this draft just because i haven't gotten around to fixing the failure, not relevant to PPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants